Give organisation members access to organisation feeds

[job79]

Currently the organisation feed only includes items for public repositories (for non-administrators). This pull requests adds notifications from private repositories to the organisation-feed (for accounts that have access to the organisation).

Feed-items only get shown for repositories where the users team(s) should have access to, this filtering seems to get done by some existing code.

Needs some tests, but am unsure where/how to add them.

Before:

After:

[wxiaoguang]

Needs some tests, but am unsure where/how to add them.

Hmm yes ..... I guess it does need tests (and yes it's not that easy to write one ......) 🤣

[job79]

Can I get some help with the unit tests? I am receiving the following error but don't understand what is going wrong.

Error Trace:	/home/runner/work/gitea/gitea/models/unittest/testdb.go:203
		/home/runner/work/gitea/gitea/routers/web/feed/profile_test.go:21
Error:      	Received unexpected error:
            	failed to load fixtures from /home/runner/work/gitea/gitea/models/fixtures/action_artifact.yml: no such table: action_artifact
Test:       	TestCheckGetOrgFeedsAsOrgMember

Adding a unit test from another package to the feed package fixes the issue, but I have absolutely no idea why. It doesn't even seem to execute before the other tests.

diff --git a/routers/web/feed/profile_test.go b/routers/web/feed/profile_test.go
index 84e6a82c35..50dc7abc8c 100644
--- a/routers/web/feed/profile_test.go
+++ b/routers/web/feed/profile_test.go
@@ -8,6 +8,7 @@ import (
        "code.gitea.io/gitea/models/unittest"
        user_model "code.gitea.io/gitea/models/user"
        "code.gitea.io/gitea/routers/web/feed"
+       "code.gitea.io/gitea/routers/web/org"
        "code.gitea.io/gitea/services/contexttest"
 
        "github.com/stretchr/testify/assert"
@@ -38,3 +39,9 @@ func TestCheckGetOrgFeedsAsNonOrgMember(t *testing.T) {
        feed.ShowUserFeedAtom(ctx)
        assert.NotContains(t, resp.Body.String(), "<entry>") // Should not contain any entries
 }
+
+func TestAddingThisTestFixesTheIssue(t *testing.T) {
+       unittest.PrepareTestEnv(t)
+       ctx, _ := contexttest.MockContext(t, "user2/-/projects/4/4")
+       org.CheckProjectColumnChangePermissions(ctx) // <- removing this line makes all tests fail
+}

[wxiaoguang]

I think the tests should work without any problem now.

[job79]

I think the tests should work without any problem now.

Thank you!