Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unnecessary comment when moving issue on the same project column #33496

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Fix unnecessary comment when moving issue on the same project column #33496

merged 3 commits into from
Feb 5, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 4, 2025

Fix #33482

@lunny lunny added type/bug backport/v1.23 This PR should be backported to Gitea 1.23 labels Feb 4, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 4, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 4, 2025
@lunny lunny mentioned this pull request Feb 4, 2025
Open
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 4, 2025
@lunny lunny mentioned this pull request Feb 4, 2025
Merged
@lunny lunny force-pushed the lunny/fix_move_same_column branch from 119471d to b84ac70 Compare February 4, 2025 19:01
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 5, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 5, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 5, 2025
@lunny lunny merged commit 6999651 into go-gitea:main Feb 5, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Feb 5, 2025
@lunny lunny deleted the lunny/fix_move_same_column branch February 5, 2025 03:51
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 5, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Feb 5, 2025
@lunny @GiteaBot
Fix unnecessary comment when moving issue on the same project column (g…
6532afa 
…o-gitea#33496)

Fix go-gitea#33482
@GiteaBot GiteaBot mentioned this pull request Feb 5, 2025
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Feb 5, 2025
lunny added a commit that referenced this pull request Feb 5, 2025
@GiteaBot @lunny
Fix unnecessary comment when moving issue on the same project column (#…
2df7d08 
…33496) (#33499)

Backport #33496 by @lunny

Fix #33482

Co-authored-by: Lunny Xiao <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 5, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6b2b9ca 
* giteaofficial/main:
  add `timetzdata` build tag to binary releases (go-gitea#33463)
  Fix unnecessary comment when moving issue on the same project column (go-gitea#33496)
  [skip ci] Updated translations via Crowdin
  Refactor web route handler (go-gitea#33488)
  Reject star-related requests if stars are disabled (go-gitea#33208)
  Fix commit status events (go-gitea#33320)
  [skip ci] Updated translations via Crowdin
  Disable cron task to update license (go-gitea#33486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Dragging items between and within columns in project boards
5 participants
@lunny @wxiaoguang @a1012112796 @hiifong @GiteaBot