Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-register OAuth application for gh-tea #33475

Closed
wants to merge 3 commits into from
Closed

Pre-register OAuth application for gh-tea #33475

wants to merge 3 commits into from

Conversation

hiifong
Copy link
Member

@hiifong hiifong commented Feb 2, 2025

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 2, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 2, 2025
@hiifong hiifong marked this pull request as draft February 2, 2025 06:51
@github-actions github-actions bot added modifies/go Pull requests that update Go code docs-update-needed The document needs to be updated synchronously labels Feb 2, 2025
@wxiaoguang
Copy link
Contributor

Since it is also a "CLI", it could re-use the "tea" 's oauth ID

delvh
delvh approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@delvh delvh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this PR WIP?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 2, 2025
@wxiaoguang
Copy link
Contributor

@delvh I still think we should do so: #33475 (comment)

Since it is also a "CLI", it could re-use the "tea" 's oauth ID

@hiifong
Copy link
Member Author

hiifong commented Feb 2, 2025

Why is this PR WIP?

Since gh-tea has not yet been completed

@hiifong
Copy link
Member Author

hiifong commented Feb 2, 2025 •
edited
Loading

@delvh I still think we should do so: #33475 (comment)

Since it is also a "CLI", it could re-use the "tea" 's oauth ID

@delvh Do you think we need to do that?

I have run the oauth2 process, and now this PR can be reviewed.

@hiifong hiifong assigned hiifong and unassigned hiifong Feb 2, 2025
@hiifong hiifong marked this pull request as ready for review February 2, 2025 16:01
wxiaoguang
wxiaoguang requested changes Feb 2, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a "request change" here.

I do not see the necessity to add more "default applications" at the moment. It only causes confusing.

Correct me if I was wrong.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 2, 2025
@hiifong
Copy link
Member Author

hiifong commented Feb 2, 2025

Put a "request change" here.

I do not see the necessity to add more "default applications" at the moment. It only causes confusing.

Correct me if I was wrong.

It seems that different apps are not allowed to use the same ClientID.
image

@wxiaoguang
Copy link
Contributor

It seems that different apps are not allowed to use the same ClientID.

I mean make gh-tea use tea's oauth id, is it possible?

@hiifong
Copy link
Member Author

hiifong commented Feb 2, 2025

It seems that different apps are not allowed to use the same ClientID.

I mean make gh-tea use tea's oauth id, is it possible?

It seems that different apps are not allowed to use the same ClientID.

I mean make gh-tea use tea's oauth id, is it possible?

If gh-tea uses tea's client id, then this pr is unnecessary.

@hiifong hiifong closed this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang requested changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
docs-update-needed The document needs to be updated synchronously lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hiifong @wxiaoguang @delvh @GiteaBot