Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README screenshots #33347

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Jan 22, 2025

@lunny @techknowlogick
Wait for the update of https://dl.gitea.com/screenshots
Can you move all old screenshots into https://dl.gitea.com/screenshots/old ?
Then run the action to upload new screenshots to https://dl.gitea.com/screenshots

Follow #33149.
As I mentioned here: #33149 (comment), the prepare process is almost finished.
The backend technical is using newly added workflow_dispatch feature for Gitea Action to take the screenshots automatically.
Then we can easily sync the screenshots to the latest version without annoying manual work.
Get more information from https://gitea.com/gitea/deployment

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 22, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 22, 2025
@silverwind
Copy link
Member

Can you show one example screenshot? Just want to verify they are in sufficient resolution etc.

@lunny
Copy link
Member

lunny commented Jan 22, 2025

Can you show one example screenshot? Just want to verify they are in sufficient resolution etc.

I believe all the screenshots have been added in https://dl.gitea.com/screenshots/2025/ .

@silverwind
Copy link
Member

I see, they look good.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 22, 2025
@silverwind
Copy link
Member

silverwind commented Jan 23, 2025

The new layout in markdown may be quite vertical (I'm not sure because preview is not working yet).

If it is one image per line, consider putting the images aside each other by removing the newlines.

@hiifong
Copy link
Member

hiifong commented Jan 23, 2025

I think it would be better to control the presentation of the screenshot through the img tag in HTML.

@silverwind
Copy link
Member

silverwind commented Jan 23, 2025

Up to you whether you do it in markdown or HTML. Benefit with HTML is you can specify width:

<div>
   <img width="200">
   <img width="200">
   <img width="200">
   <img width="200">
</div>

@silverwind silverwind self-requested a review January 23, 2025 15:48
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 23, 2025
@yp05327
Copy link
Contributor Author

yp05327 commented Jan 24, 2025

Up to you whether you do it in markdown or HTML. Benefit with HTML is you can specify width:

Users may have different resolutions, if the width is a const, it may be too small or too big?
Then use css to fix this issue? Then readme may include may html codes?
This is my thought about this.

@silverwind
Copy link
Member

silverwind commented Jan 24, 2025

Users may have different resolutions, if the width is a const, it may be too small or too big?

Resultion of the thumnails will be greatly sufficient, I'd say put 2-4 per line.

Then use css to fix this issue? Then readme may include may html codes?

Markdown does not allow CSS. Only a limited set of HTML attributes work.

Ideally I'd wrap each screenshot in a link, e.g. <a><img></a>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants