Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an older image of mssql #32044

Closed
wants to merge 2 commits into from
Closed

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 14, 2024

Recently MSSQL tests received the error TLS Handshake failed: tls: failed to parse certificate from server: x509: negative serial number. To test whether it's caused by a recent upgrade of mssql image, this PR revert the mssql image to an older one.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 14, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 14, 2024
@yp05327
Copy link
Contributor

yp05327 commented Sep 17, 2024

No errors from test-mssql, so the latest version is related?

@yp05327
Copy link
Contributor

yp05327 commented Sep 17, 2024

@lunny
I think this is related: microsoft/mssql-docker#895

Some details:

Before Go 1.23, ParseCertificate accepted certificates with negative serial numbers. This behavior can be restored by including "x509negativeserial=1" in the GODEBUG environment variable.

From microsoft/go-mssqldb#217

@lunny lunny mentioned this pull request Sep 17, 2024
@lunny lunny closed this Sep 17, 2024
@lunny lunny deleted the lunny/test_mssql_image branch September 17, 2024 17:23
@lunny lunny restored the lunny/test_mssql_image branch September 19, 2024 21:59
@lunny lunny reopened this Sep 19, 2024
@lunny lunny closed this Sep 20, 2024
@lunny lunny deleted the lunny/test_mssql_image branch September 20, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/internal size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants