Introduce --page-space-bottom at 64px

[silverwind]

Previously we would always leave 80px space before the page footer, but this is problematic with small viewport heights on projects page for example. I think it' ideal that we use --page-spacing which is already in use for spacing on top of the page.

The secondary-nav margin is also adjusted as I see no value why this shouldn't be the same value.

[lunny]

Why not 80px? I'm suitable to have more space. Too little space makes me feel stressful.

[silverwind]

Take for example project view on small viewport height:

In this case, a third of the height is wasted by this empty space. With 16px, the space is used much more efficiently:

Not sure how common such viewport heights are but I often see this problem when I have DevTools open.

[silverwind]

Likely should use a new variable like --page-margin-y or --page-margin-bottom.

[lunny]

Take for example project view on small viewport height:

In this case, a third of the height is wasted by this empty space. With 16px, the space is used much more efficiently:

Not sure how common such viewport heights are but I often see this problem when I have DevTools open.

I personally don't think they are a waste. I like the first one. I like the relaxed feeling. Maybe --page-margin-bottom is a better name.

[wxiaoguang]

Take for example project view on small viewport height:

The project view has been improved by " Add fullscreen mode as a more efficient operation way to view projects #34081 " . Even in non-fullscreen mode, the column heights are all correctly set by vh, so the UI should be better than before, and most users do not need to pay attention to the "bottom space" now.

So the "bottom padding" could be kept as old, I also agree that the old design looks more comfortable.

[silverwind]

Maybe we should reduce it slightly from 80px to 64px to match GitHub, and introduce a CSS variable for it:

[silverwind]

I've now added the variable and set it to 64px, matching GitHub:

[silverwind]

Looking good now? The variable name can be bikeshed over, it's actually setting padding now but is called margin.

[wxiaoguang]

Looking good now? The variable name can be bikeshed over, it's actually setting padding now but is called margin.

Maybe page-space-bottom is better

[silverwind]

Renamed.