commands: Set nspawn console mode to pipe #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the default nspawn console mode for nspawn is interactive which means that /dev/console is created inside the nspawn container and the command can assume it is running in an interactive session. With console mode set to pipe, nspawn doesn't create /dev/console inside the container and scripts assume they are running in an interactive environment This has the benefit of forcing some commands (e.g. apt) to not show things like progress bars which only work in interactive terminals. Fixes: #411 Fixes: #416 Signed-off-by: Christopher Obbard <[email protected]>
sjoerdsimons
approved these changes
Feb 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the default nspawn console mode for nspawn is interactive which means that /dev/console is created inside the nspawn container and the command can assume it is running in an interactive session.
With console mode set to pipe, nspawn doesn't create /dev/console inside the container and scripts assume they are running in an interactive environment
This has the benefit of forcing some commands (e.g. apt) to not show things like progress bars which only work in interactive terminals.
Fixes: #411
Fixes: #416