Add option to quiet fakemachine #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bergmx Thanks for this, I think i'd rather disable the fakemachine invocation log message by default (e.g. It may be nicer to disable the message by default and have |
|
Sounds good to me! I made new commit with that change. |
obbardc
requested changes
Jan 31, 2024
bergmx
force-pushed
the
add-option-to-quiet-fakemachine
branch
from
afb8cd4
to
c7b54c6
Compare
|
Hi again @obbardc ! Looks like the merge is blocked. I can't see anything I can do on my end, so maybe there's a button to press on your end? Let me know if there is something I have to do. |
obbardc
approved these changes
Feb 1, 2024
|
I had to review it again manually! Should be all done now though. Thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the work on this useful project.
We have successfully been using debos for some time, but it always prints the whole debos invocation, which causes secrets passed into debos as variables (e.g. account passwords, private keys) to be written to our CI logs. I looked into this and found that it was because fakemachine logs the command it runs by default, though it has an option to suppress this. I saw no way of setting this option through debos, though, hence this pull request.
This pull request adds the flag "--quiet-fakemachine" because it was the least intrusive change, but on a second thought, it looks a bit odd. I think it might make more sense to use the quiet option in fakemachine by default, and let the existing debos flag "--verbose" disable it instead. What do you think? Any approach that lets us pass a variable without having it written to log is fine with us.