Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Install archlinux-keyring from source #455

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

obbardc
Copy link
Member

@obbardc obbardc commented Dec 5, 2023

The arch linux tests require a newer version of archlinux-keyring than what is in Debian stable; so revert back to pulling the latest version.

This partially reverts 36cf333.

@obbardc obbardc self-assigned this Dec 5, 2023
@evelikov
Copy link

evelikov commented Dec 5, 2023

Should probably add a scarier inline message, otherwise the next person will remove the code.

@obbardc
Copy link
Member Author

obbardc commented Dec 5, 2023

Should probably add a scarier inline message, otherwise the next person will remove the code.

Do you have a suggestion?

# WARNING: removing this will most likely break archlinux support is not good enough ?

@obbardc obbardc force-pushed the wip/obbardc/fix-arch-tests branch 2 times, most recently from a43c505 to 940890a Compare December 5, 2023 12:00
@evelikov
Copy link

evelikov commented Dec 5, 2023

# Pull the latest archlinux-keyring, since the one in Debian is bound
# to get outdated sooner or later.
# WARNING: removing this will most likely break archlinux support

How about something like this in both places?

Edit: A reference to a closed/fixed issue is misleading at best.

@obbardc
Copy link
Member Author

obbardc commented Dec 5, 2023

@evelikov Can we pull the master branch of the keyring ? Seems like the tag you originally used is outdated (before the version in Debian, which is most lilkely why it was replaced with the keyring pacakge in Debian).

@evelikov
Copy link

evelikov commented Dec 5, 2023

Nice one - completely forgot we're using a tag. Switching to master or fishing out automatically picking* the newest tag, would be better.

The arch linux tests require a newer version of archlinux-keyring than
what is in Debian stable; so revert back to pulling the latest version.

This partially reverts 36cf333.

Signed-off-by: Christopher Obbard <[email protected]>
@obbardc
Copy link
Member Author

obbardc commented Dec 6, 2023

@evelikov How does this look now then?

@obbardc obbardc added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit d092c54 Dec 7, 2023
58 checks passed
@sjoerdsimons sjoerdsimons deleted the wip/obbardc/fix-arch-tests branch January 19, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants