Be nicer to non-amd64 hosts #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we assume `debos` will run only on `amd64` hosts. However, `fakemachine` recently gained the ability to run on `arm64` hosts, so we shouldn't make this assumption anymore. This change only sets the path to `qemu` when building for a foreign arch, instead of setting it for all architectures except x86 ones. Signed-off-by: Arnaud Ferraris <[email protected]>
This change marks the target architecture as "foreign" if it differs from the current host architecture, instead of hardcoding an expected host architecture. Due to Debian architectures not translating directly to their Go equivalents (like `mips*el` being `mips*le` instead, or `i386` being simply `386` in Go), this will only work for `amd64`, `arm64` and `riscv64` hosts. However, it seems unlikely running `debos` on a 32-bit host (or even on `mips64el`) will become a compelling use-case in the future, making this issue an acceptable limitation. Signed-off-by: Arnaud Ferraris <[email protected]>
sjoerdsimons
force-pushed
the
improve-non-amd64
branch
from
0fd2d92
to
ac477e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With fakemachine now being compatible with arm64 hosts, it is possible to build and run debos on this architecture. However, it will still assume it runs on amd64, hence executing actions in the chroot through qemu and calling debootstrap with the
--foreignflag set, even when building for the same architecture.This PR makes use of runtime architecture detection to avoid those unnecessary tricks.