Check if artifactdir exists early #429
Open
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently debos fails if an action attempts to use artifactdir and it doesn't exist on the host: $ debos --artifactdir=out rpi64/debimage-rpi64.yaml Action `image-partition` failed at stage PreMachine, error: open /home/obbardc/projects/debos/debos-recipes/out/debian-rpi64.img: no such file or directory Check that artifactdir exists early and return an error in case that it does not exist. Closes: #426 Signed-off-by: Christopher Obbard <[email protected]>
obbardc
force-pushed
the
wip/obbardc/artifactdir-improvements
branch
from
e3869f8
to
f334d32
Compare
obbardc
commented
Aug 21, 2023
|
Do we need a test case for this? |
| @@ -192,6 +192,11 @@ func main() { | |||
| context.Artifactdir, _ = os.Getwd() | |||
| } | |||
| context.Artifactdir = debos.CleanPath(context.Artifactdir) | |||
| if _, err := os.Stat(context.Artifactdir); os.IsNotExist(err) { | |||
There was a problem hiding this comment.
should check if it's a Dir as well :)
sjoerdsimons
requested changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently debos fails if an action attempts to use artifactdir and it doesn't exist on the host:
$ debos --artifactdir=out rpi64/debimage-rpi64.yaml
Action
image-partitionfailed at stage PreMachine, error: open /home/obbardc/projects/debos/debos-recipes/out/debian-rpi64.img: no such file or directoryCheck that artifactdir exists early and return an error in case that it does not exist.
Closes: #426