-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit old suite workaround #390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @obbardc |
Potential further improvements:
WDYT? |
obbardc
requested changes
Jan 3, 2023
obbardc
reviewed
Jan 3, 2023
andhe
force-pushed
the
limit-361-workaround
branch
from
January 3, 2023 11:38
b222923
to
b71a45e
Compare
The workaround for go-debos#361 that was applied in go-debos@b3c1f76 breaks recipes for bookworm and newer. Signed-off-by: Andreas Henriksson <[email protected]>
andhe
force-pushed
the
limit-361-workaround
branch
from
January 3, 2023 11:42
b71a45e
to
18998ff
Compare
andhe
commented
Jan 3, 2023
Manually tested PR and it fixes testing/unstable/bullseye cases and also works with Apertis (a downstream based on buster) \o/ |
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround for #361 that was applied in b3c1f76 breaks recipes for bookworm and newer.
This change makes the workaround less damaging (should atleast work with official debian releases for the forseeable future), while still far from perfect (any derivate distribution that is bookworm-based will fail).