-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skeletal DOCX support #334
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,6 @@ | |||
*obj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would we need an .cvsignore file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am really not sure whether we should actually implement this converter ourselves. In my view it would be better to have LibreOffice or any other program convert this format to or from RTF(D)
@@ -0,0 +1,51 @@ | |||
/* docxConsumer.h created by gcasa Feb-2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalization of the file name seems to be wrong.
@@ -0,0 +1,94 @@ | |||
/* attributedStringConsumer.m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file name is wrong.
|
||
Copyright (C) 1999 Free Software Foundation, Inc. | ||
|
||
Author: Stefan B�hringer ([email protected]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather attribute this file to yourself.
|
||
@implementation DOCXConsumer | ||
|
||
/* RTFConsumer is the principal class and thus implements this */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment seems to be a leftover
|
||
#import <Foundation/Foundation.h> | ||
#import <AppKit/AppKit.h> | ||
#import <GNUstepGUI/GSHelpAttachment.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you are going to need this?
|
||
Copyright (C) 1999 Free Software Foundation, Inc. | ||
|
||
Author: Stefan B�hringer ([email protected]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again the wrong author
@@ -0,0 +1,47 @@ | |||
# GNUmakefile | |||
# | |||
# Copyright (C) 2001 Free Software Foundation, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a new file, you should update the date an add yourself as the author.
@@ -0,0 +1,31 @@ | |||
# GNUmakefile.postamble | |||
# | |||
# Copyright (C) 2001 Free Software Foundation, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Hmm.... I wasn't sure if we could use those parsers or not. if we can, that would be ideal. |
@fredkiefer Should these classes link to those parsers to achieve compatibility? How can we implement what you're suggesting? |
Add DOCX support to GUI.