Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GSW-1984] swap route debounce #597

Merged
merged 5 commits into from
Dec 31, 2024
Merged

[GSW-1984] swap route debounce #597

merged 5 commits into from
Dec 31, 2024

Conversation

tfrg
Copy link
Collaborator

@tfrg tfrg commented Dec 23, 2024 •
edited
Loading

Description

  • Instant API call whenever a user enters a swap amount
  • Multiple unnecessary API calls during the input process
  • Increase server load

Details

  • Optimising API calls with debounce
  • Wait a certain amount of time (500ms) after user input is complete before calling the API
  • Eliminate unnecessary intermediate requests
  • Reduce server load

@vercel Vercel
Copy link

vercel bot commented Dec 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gnoswap-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 9:37am

@tfrg tfrg added the DO NOT MERGE Required to check merge timing label Dec 23, 2024
@tfrg tfrg force-pushed the GSW-1984-swap-route-debounce branch from 6c4e758 to 45ba371 Compare December 23, 2024 12:13
@tfrg tfrg force-pushed the GSW-1984-swap-route-debounce branch from bd1f54d to 9917cc1 Compare December 26, 2024 12:05
@tfrg tfrg removed the DO NOT MERGE Required to check merge timing label Dec 31, 2024
jinoosss
jinoosss previously approved these changes Dec 31, 2024
View reviewed changes
tfrg added 5 commits December 31, 2024 18:34
@tfrg
feat: [GSW-1984] Swap Value Debounce
a78c026
@tfrg
fix: SwapSummaryInfo UI (u-units)
83f6f3a
@tfrg
refactor: [SonarQube] Ternary operators should not be nested
53d5511 
Extract this nested ternary operation into an independent statement.
Ternary operators should not be nested typescript:S3358
Software qualities impacted:
Maintainability
@tfrg
fix: MissingLogo UI (font-size)
1b48d3e
@tfrg
fix: [GSW-1984] Improve State management (User now typing)
3864259
@tfrg tfrg force-pushed the GSW-1984-swap-route-debounce branch from 8c417e1 to 3864259 Compare December 31, 2024 09:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tfrg tfrg merged commit ea9ea82 into develop Dec 31, 2024
6 checks passed
@tfrg tfrg deleted the GSW-1984-swap-route-debounce branch December 31, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinoosss jinoosss jinoosss approved these changes

@dongwon8247 dongwon8247 dongwon8247 approved these changes

@notJoon notJoon Awaiting requested review from notJoon

@onlyhyde onlyhyde Awaiting requested review from onlyhyde

@roje1 roje1 Awaiting requested review from roje1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tfrg @dongwon8247 @jinoosss