[GSW-1987] optimize swap route #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tfrg
force-pushed
the
GSW-1987-optimize-swap-route
branch
from
f407c78 to
23c82f2
Compare
jinoosss
approved these changes
Dec 31, 2024
tfrg
force-pushed
the
GSW-1987-optimize-swap-route
branch
from
28fbf92 to
cec71f4
Compare
|
dongwon8247
approved these changes
Dec 31, 2024
notJoon
requested changes
Dec 31, 2024
Comment on lines
+133
to
+143
| if (swapRateAction === "ATOB") { | ||
| if (!tokenBUSD || tokenBUSD === 0) return "-"; | ||
| return `($${convertToKMB(floorNumber((tokenBUSD / Number(tokenBAmount)) * swapRate).toFixed(3), { | ||
| isIgnoreKFormat: true, | ||
| })})`; | ||
| } else { | ||
| if (!tokenAUSD || tokenAUSD === 0) return "-"; | ||
| return `($${convertToKMB(floorNumber((tokenAUSD / Number(tokenAAmount)) * swapRate).toFixed(3), { | ||
| isIgnoreKFormat: true, | ||
| })})`; | ||
| } |
There was a problem hiding this comment.
seems duplicate. how about make this as an function?
const formatPrice = (usd: number, amount: number): string => {
if (!usd || !amount) return '-'; // xxx: not sure about the condition.
const calculated = (usd / amount) * swapRate;
const flooredValue = floorNumber(calculated.toFixed(3), {
isIgnoreKFormat: true,
});
return `($${convertToKMB(flooredValue, { isIgnoreKFormat: true })})`;
};
if (swapRateAction === 'ATOB') {
return formatPrice(tokenBUSD, tokenBAmount);
} else {
return formatPrice(tokenAUSD, tokenAAmount);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Details