Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GSW-1982] sync price impact calculation #595

Merged
merged 5 commits into from
Dec 31, 2024
Merged

[GSW-1982] sync price impact calculation #595

merged 5 commits into from
Dec 31, 2024

Conversation

tfrg
Copy link
Collaborator

@tfrg tfrg commented Dec 23, 2024 •
edited
Loading

Description

  • UI flickering due to timing issues with price impact calculation

Details

  • Improved synchronous calculation of price impact on the client

@vercel Vercel
Copy link

vercel bot commented Dec 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gnoswap-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 5:53am

@tfrg tfrg added the DO NOT MERGE Required to check merge timing label Dec 23, 2024
notJoon
notJoon previously approved these changes Dec 24, 2024
View reviewed changes
@tfrg tfrg dismissed notJoon’s stale review December 26, 2024 03:46

The merge-base changed after approval.

@tfrg tfrg force-pushed the GSW-1982-sync-price-impact-calculation branch from 9f91141 to 828b973 Compare December 26, 2024 03:46
@tfrg tfrg removed the DO NOT MERGE Required to check merge timing label Dec 30, 2024
tfrg added 4 commits December 30, 2024 12:19
@tfrg
fix: [GSW-1982] Price impact calculating timing
1d8256a
@tfrg
fix: [GSW-1982] u-units applied to display values (SwapCard, SwapConf…
2c2e7b7 
…irmModal)
@tfrg
refactor: [SonarQube] Remove redundant return statement in swap state…
9f13bfb 
… handling

Remove this redundant jump.
Jump statements should not be redundant typescript:S3626
Software qualities impacted:
Maintainability
@tfrg
refactor: [SonarQube] replace || operator with utility func
34c981a 
Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.
Nullish coalescing should be preferred typescript:S6606
Software qualities impacted:
Maintainability
@tfrg tfrg force-pushed the GSW-1982-sync-price-impact-calculation branch from 828b973 to 34c981a Compare December 30, 2024 03:19
notJoon
notJoon previously approved these changes Dec 30, 2024
View reviewed changes
@dongwon8247
Copy link
Member

dongwon8247 commented Dec 31, 2024 •
edited
Loading

@tfrg 영진님 Price impact 업데이트 되는 주기도 fetching 주기랑 맞추기로 한 내용을 여기 pr에 넣고 머지하면 좋을 것 같은데 어떠세요? 어떻게 맞출지는 진우님과 논의해보고 정해서 작업해주시면 될 것 같아요 @jinoosss

@jinoosss
Copy link
Member

jinoosss commented Dec 31, 2024 •
edited
Loading

@tfrg ,
When fetching the price to the swap router,
you need to consider the refactor cycle of the API that fetches the token price (it would be nice to match the refactor cycle of the router API).

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tfrg tfrg merged commit 99a9396 into develop Dec 31, 2024
6 checks passed
@tfrg tfrg deleted the GSW-1982-sync-price-impact-calculation branch December 31, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinoosss jinoosss jinoosss approved these changes

@notJoon notJoon notJoon approved these changes

@onlyhyde onlyhyde Awaiting requested review from onlyhyde

@roje1 roje1 Awaiting requested review from roje1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tfrg @dongwon8247 @jinoosss @notJoon