[GSW-416] feat: Integrate Pools API #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
harryoh
reviewed
Oct 13, 2023
| NEXT_PUBLIC_API_URL="https://dev-api.gnoswap.io/v3/testnet" | ||
| NEXT_PUBLIC_PACKAGE_POOL_PATH="gno.land/r/pool" | ||
| NEXT_PUBLIC_PACKAGE_POOL_ADDRESS="g1ee305k8yk0pjz443xpwtqdyep522f9g5r7d63w" |
There was a problem hiding this comment.
It has POOL_PATH, but does it need to know the address? Is there any way to find out?
There was a problem hiding this comment.
But if the task makes more complicated, it may be okay to just use two variables.
There was a problem hiding this comment.
We can implement an algorithm that generates an address from a path.
However, we must utilize a crypto library such as bech32.
I'm not sure which one is better, what do you think?
There was a problem hiding this comment.
First, let's use two variables.
harryoh
approved these changes
Oct 13, 2023
| NEXT_PUBLIC_API_URL="https://dev-api.gnoswap.io/v3/testnet" | ||
| NEXT_PUBLIC_PACKAGE_POOL_PATH="gno.land/r/pool" | ||
| NEXT_PUBLIC_PACKAGE_POOL_ADDRESS="g1ee305k8yk0pjz443xpwtqdyep522f9g5r7d63w" |
There was a problem hiding this comment.
First, let's use two variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.