fix: [GSW-2032] Reduce cognitive complexity

Refactor this function to reduce its Cognitive Complexity from 60 to the 15 allowed. Cognitive Complexity of functions should not be too high typescript:S3776 Software qualities impacted: Maintainability
gnoswap-labs · Dec 18, 2024 · 4c5e499 · 4c5e499
1 parent c8e7c81
commit 4c5e499
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 26 deletions.
diff --git a/...es/web/src/layouts/earn/containers/earn-my-position-container/EarnMyPositionContainer.tsx b/...es/web/src/layouts/earn/containers/earn-my-position-container/EarnMyPositionContainer.tsx
@@ -174,19 +174,13 @@ const EarnMyPositionContainer: React.FC<EarnMyPositionContainerProps> = ({ addre
           ],
         );
 
-        let nextIndex = maybeNextDisplayIndex;
-
-        switch (minLength) {
-          case previousElementCenterXToScreenCenterX:
-            nextIndex = maybeNextDisplayIndex - 1;
-            break;
-          case nextElementCenterXToScreenCenterX:
-            nextIndex = maybeNextDisplayIndex + 1;
-            break;
-          case currentElementCenterXToScreenCenterX:
-            nextIndex = maybeNextDisplayIndex;
-            break;
-        }
+        const distanceMap = {
+          [previousElementCenterXToScreenCenterX]: maybeNextDisplayIndex - 1,
+          [currentElementCenterXToScreenCenterX]: maybeNextDisplayIndex,
+          [nextElementCenterXToScreenCenterX]: maybeNextDisplayIndex + 1,
+        };
+
+        const nextIndex = distanceMap[minLength];
 
         if (nextIndex > childrenLength) {
           setCurrentIndex(childrenLength);

diff --git a/...rn/containers/incentivized-pool-card-list-container/IncentivizedPoolCardListContainer.tsx b/...rn/containers/incentivized-pool-card-list-container/IncentivizedPoolCardListContainer.tsx
@@ -125,19 +125,13 @@ const IncentivizedPoolCardListContainer: React.FC = () => {
           ],
         );
 
-        let nextIndex = maybeNextDisplayIndex;
-
-        switch (minLength) {
-          case previousElementCenterXToScreenCenterX:
-            nextIndex = maybeNextDisplayIndex - 1;
-            break;
-          case nextElementCenterXToScreenCenterX:
-            nextIndex = maybeNextDisplayIndex + 1;
-            break;
-          case currentElementCenterXToScreenCenterX:
-            nextIndex = maybeNextDisplayIndex;
-            break;
-        }
+        const distanceMap = {
+          [previousElementCenterXToScreenCenterX]: maybeNextDisplayIndex - 1,
+          [currentElementCenterXToScreenCenterX]: maybeNextDisplayIndex,
+          [nextElementCenterXToScreenCenterX]: maybeNextDisplayIndex + 1,
+        };
+
+        const nextIndex = distanceMap[minLength];
 
         if (nextIndex > childrenLength) {
           setCurrentIndex(childrenLength);