Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit feedback #141

Merged
merged 15 commits into from
Oct 26, 2023
Merged

Audit feedback #141

merged 15 commits into from
Oct 26, 2023

Commits on Oct 12, 2023

  1. Break down Modifier authorization logic in reusable parts

    @cristovaoth
    cristovaoth committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c74a97c View commit details
    Browse the repository at this point in the history

  2. Add failing tests

    @cristovaoth
    cristovaoth committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    6e65220 View commit details
    Browse the repository at this point in the history

  3. Changing the base SignatureChecker to work with user proposed salt, i… 

    …nstead of self managed nonce
    @cristovaoth
    cristovaoth committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c086848 View commit details
    Browse the repository at this point in the history

  4. Introduce execution tracking into Modifier.sol based on executed and … 

    …invalidated hashes
    @cristovaoth
    cristovaoth committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    13b826e View commit details
    Browse the repository at this point in the history

  5. Rename auxiliary function

    @cristovaoth
    cristovaoth committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e5a977f View commit details
    Browse the repository at this point in the history

  6. Moving the newly introducedd errors into ExecutionTracker

    @cristovaoth
    cristovaoth committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b80933d View commit details
    Browse the repository at this point in the history

  7. Fully cover guard with tests

    @cristovaoth
    cristovaoth committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    260ce31 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Make sentOrSigned by an internal helper function for Modifiers

    @cristovaoth
    cristovaoth committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    c6775a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Make moduleTxSignedBy return always the hash, even when no signer fou… 

    …nd recovered
    @cristovaoth
    cristovaoth committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    b7e0ee3 View commit details
    Browse the repository at this point in the history

  2. Consolidate hash tracking into one mapping

    @cristovaoth
    cristovaoth committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    b2f8089 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Ensure contract specific signature is sliced correctly

    @cristovaoth
    cristovaoth committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    e71c183 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Simplify splitSignature, and pull up logic that assembles the isValid… 

    …ContractSignature call
    @cristovaoth
    cristovaoth committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    8095be1 View commit details
    Browse the repository at this point in the history

  2. Add test for contract specific signature empty

    @cristovaoth
    cristovaoth committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    01a8484 View commit details
    Browse the repository at this point in the history

  3. Remove aux variable

    @cristovaoth
    cristovaoth committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    c9d6904 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Consistently return hash from moduleTxSignedBy()

    @cristovaoth
    cristovaoth committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9257ba7 View commit details
    Browse the repository at this point in the history