Remove Roles V2 #138
Merged
Remove Roles V2 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were a bit overzealous adding Roles V2. The contracts are undergoing to updates and final audits and we'll have to update init data and master copy addresses.
The change broke the zodiac Safe app, which by default deploys the latest version of any mod. So it started deploying Roles mod at v2.0, while the zodiac app UI is only compatible with v1 atm.
This PR removes Roles V2 from the zodiac package and upgrading to this version will resolve the issue in the Safe app.