Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get modules paginated #124

Merged
merged 8 commits into from
Jul 24, 2023
Merged

Conversation

cristovaoth
Copy link
Contributor

Fixes 112

modifier.getModulesPaginated(user2.address, 1)
).to.be.revertedWith(`InvalidModule`);
});
it("returns empty array if no modules are enabled.", async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this test is duplicated immediately below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@auryn-macmillan
Copy link
Member

@cristovaoth, I was going to merge this, but it looks like some tests are failing.

Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@auryn-macmillan auryn-macmillan merged commit 76ea7bc into master Jul 24, 2023
@auryn-macmillan auryn-macmillan deleted the fix-get-modules-paginated branch July 24, 2023 02:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply fix for getModulesPaginated()
2 participants