feat: handle companion app in manifest #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
frontendphil
force-pushed
the
feat/handle-companion-app-in-manifest
branch
from
3cf553a to
540a238
Compare
Deploying zodiac-pilot with
|
| Latest commit: |
2cceaa1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://838186bb.zodiac-pilot-29m.pages.dev |
| Branch Preview URL: | https://feat-handle-companion-app-in.zodiac-pilot-29m.pages.dev |
Deploying zodiac-pilot-connect with
|
| Latest commit: |
2cceaa1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9386aafa.zodiac-pilot.pages.dev |
| Branch Preview URL: | https://feat-handle-companion-app-in.zodiac-pilot.pages.dev |
Coverage Report for deployables/extension
File Coverage
|
||||||||||||||||||||||||||||||||||||||
frontendphil
force-pushed
the
feat/handle-companion-app-in-manifest
branch
from
5966aa6 to
2cceaa1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #469
The companion app should eventually take over what the connect app does currently. Since we might want to integrate the extension and the companion app more closely, we need to be able to dynamically tell the extension where the companion app resides (e.g., during development, you might want the URL to point to a local instance instead of the deployed one).
This PR introduces a new
CONNECT_IFRAME_URLenvironment variable and also creates themanifest.jsondynamically when the app builds. This way, we can ensure that the manifest reflects the current development setup and that URL rules also reflect this.