Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move ensureIframe method out of global scope #388

Merged

Conversation

frontendphil
Copy link
Member

Fixes #381

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-pilot-example-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 9:05am

Copy link

Deploying zodiac-pilot with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4bb036d
Status: ✅  Deploy successful!
Preview URL: https://740b9d98.zodiac-pilot-29m.pages.dev
Branch Preview URL: https://fix-weird-build-error-preven.zodiac-pilot-29m.pages.dev

View logs

Copy link

Deploying zodiac-pilot-connect with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4bb036d
Status: ✅  Deploy successful!
Preview URL: https://3b913ac0.zodiac-pilot.pages.dev
Branch Preview URL: https://fix-weird-build-error-preven.zodiac-pilot.pages.dev

View logs

Copy link

github-actions bot commented Dec 18, 2024

Coverage Report for extension

Status Category Percentage Covered / Total
🔵 Lines 63.66% 5356 / 8413
🔵 Statements 63.66% 5356 / 8413
🔵 Functions 71.61% 333 / 465
🔵 Branches 79.27% 826 / 1042
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
extension/src/connect/contentScripts/dApp.ts 54.65% 50% 100% 54.65% 36-69, 77-78, 84-87, 99-100, 114-119
Generated in workflow #212 for commit 4bb036d by the Vitest Coverage Report Action

Copy link
Collaborator

@jfschwarz jfschwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my god.... 😓

@frontendphil frontendphil merged commit 1683c65 into main Dec 18, 2024
12 checks passed
@frontendphil frontendphil deleted the fix/weird-build-error-preventing-meta-mask-connect branch December 18, 2024 10:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect to MetaMask is disabled 🔥🔥🔥
2 participants