Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconciled parallel work #3

Closed
wants to merge 5 commits into from
Closed

Reconciled parallel work #3

wants to merge 5 commits into from

Conversation

belimoth
Copy link
Contributor

No description provided.

@gnomon-
Copy link
Owner

gnomon- commented Aug 14, 2018

I like the work in this a lot, thank you!! Big fan in particular of the Python script for doing the character set conversion - I was wrestling around with iconv and it felt like a frustrating dead end.

Do you mind if I leave this un-merged for a little while? My plan here is first to transcribe exactly what's in the PDF, then overlay the character set corrections, then overlay the line wrapping corrections, so that the resulting repo simultaneously serves as (1) a faithful record of the original document, (2) a documented set of transformation steps, and (3) a correct, machine-readable, compilable program. I feel like your corrections definitely move towards (3) and set the stage for (2) but they're a bit at odds with (1) right now.

In the short term though I would love to pull it in on a non-master branch, if you're cool with that!

@belimoth
Copy link
Contributor Author

Go ahead ya, I did the character fixes in advance so I could benefit from syntax highlighting; easy enough to switch between.

There are a handful of character-level differences that are worth merging if you ignore the boxing and wrapping, I took the differences between the two transcriptions after unfixing mine and compared against original.

@belimoth belimoth mentioned this pull request Aug 15, 2018
@belimoth
Copy link
Contributor Author

continued at #4

@belimoth belimoth closed this Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants