pgs 21-25 #10
pgs 21-25 #10
Conversation
furbysource.asm
Outdated
|
|
||
| LDA #05 ; | ||
| STA Moff_len ; |
There was a problem hiding this comment.
I think this line might need to be:
STA Moff_len ;set motor off pulse timing
| Include Dieg7.asm ;asm file | ||
|
|
||
| ; ****** Only called by diagnostic speech routines ********* |
There was a problem hiding this comment.
There definitely some oddities in the source file on lines 525-531 - lots of "a" characters that look like they're being rendered as something almost indistinguishable from "e" characters. (I don't think there are faults in your transcription here, I just want to make a note for future reference that there may be some trouble on these pages.)
FIXME: check back here when more of the PDF is transcribed to see if a Dieg7.asm file exists or whether it should be Diag7.asm instead
There was a problem hiding this comment.
A-116 - A-125 is the source code of that file, and it seems like that has the same issue. Looks like an a on most pages.
There was a problem hiding this comment.
Did notice this too, but if you copy/past from the PDF, it copies as 'a's, so I went with that
EDIT: or not. I was torn on it, came to the decision to go with a's but I think I forgot to change it back to a's. This does beg the question again, do we stick to what we see in the PDF (clearly 'e') or do we stick to the spirit and interpret that as an 'a'?
My vote is sticking to the spirit. Dieg7.asm is obviously meant to be Diag7.asm. There are also some multi-line comments that will need to be cleaned up, and other issues will probably present themselves in the future.
furbysource.asm
Outdated
| INC TEMP1 ;random counter | ||
| LDA Stat_4 ;system | ||
| AND #DFh |
There was a problem hiding this comment.
I think this line should be:
AND #DFh ;clear any prev feed sw senses
furbysource.asm
Outdated
|
|
||
| LDA Pot_timeL2 ;get current count | ||
| STA Pot_ imeL ;save in motor routine counter |
There was a problem hiding this comment.
I know the t character is missing from Pot_ imeL in the PDF, but it may have to be added here just for syntactic correctness.
What do you think - does this kind of fix belong in the layer where we're simply transcribing what's in the PDF, or should there be one layer where the PDF is simply transcribed as faithfully as possible and another layer (maybe a separate script) which fixes up things that are obviously wrong to produce a compile-able ASM file? I feel like there is a decision to make here, but it's definitely not one I should make on my own without your input.
There was a problem hiding this comment.
That is a very good question, especially since later there are comments that straddle two lines. I was originally transcribing with the intent of being true to the source, but I'm starting to think it might be more prudent to make these small changes (i.e. adding in obvious letters, keeping comments on one line) at this point in the process.
| ; Do wake up routine : | ||
|
|
||
| lda #Global_time ;reset timer to trigger sensor learning |
There was a problem hiding this comment.
Making a note: spirit would capitalize lda, exactness would leave it to mimic the document
|
Made requested changes, noticed some other errors that I fixed. |
Double checked these this time, hopefully no issues.