-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODO demo/pagination #868
TODO demo/pagination #868
Conversation
See: #866, or for a deeper dive the README @ the package posed for review. Literally just posted an issue (#869) + self-critique (largely that encapsulation is needed for most of the core structs) related to it. The issue I've framed largely revolves around an API "renderer" extended version of the supposed To that end, I feel like the resolve of #575 will be of consequence to determining how the API/JSON oriented rendering support would look (especially if a self-determined Alchemy/Infura-esque functionality is chased), so I'd love feedback on that, while also being more than happy to delve into pagination (which IMO will likely depend a lot on the underlying contract/package implementation and the datatypes used, but would be happy to discuss a version that's more implementation agnostic.... re-inventing the wheel in general form is about my favorite thing to do, since there's also nothing new under the sun so... that's realistically all we ever do :P) Happy to discuss more :) |
Hi @proggR! Thank you for your comments, they are useful but I think they fall a bit out of scope here. If you still want to discuss them, I propose taking over the conversation to #866 and #869. (I know you have not received much feedback, we're trying our best to do good github issue/PR management but we're still largely improving). If you're still interested working on this mention me on either of them and I can give you my 2cs and help you drive this forward. As for this PR, seeing as the work is being continued by @Doozers in #883, I am closing it for clarity in our PR lists; and proposing that PR be re-created to target master directly. |
- add `p/demo/avl/pager` - update `r/demo/users` Hey reviewers, in addition to what you wanted to review, I'm specifically curious if you have any better API/usage ideas. Example: https://github.com/gnolang/gno/pull/2584/files#diff-8d5cbbe072737a7f288f74adcaaace11cacc3d31264e6a001515fcae824394e2R33 Related with #447, #599, #868 --------- Signed-off-by: moul <[email protected]> Co-authored-by: Antonio Navarro Perez <[email protected]> Co-authored-by: Leon Hudak <[email protected]>
TODO someone should try to complete this PR. The immediate todos are marked by XXX.
@moul can you please assign to someone who wants to work on gno programming?