Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnovm/softfloat): replace copy.sh with Go generator #3584

Merged
merged 10 commits into from
Jan 28, 2025

Conversation

omarsy
Copy link
Member

@omarsy omarsy commented Jan 22, 2025

No description provided.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jan 22, 2025
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 22, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 22, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: omarsy/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@omarsy omarsy force-pushed the fix/ci-soft-float branch from 095ad75 to f993d9c Compare January 22, 2025 18:48
@omarsy omarsy changed the title fix(ci): replace copy script with Go generator for softfloat files + make imports work with make fmt fix(ci): replace copy.sh with Go generator for softfloat files and reorganize imports in runtime_softfloat64_test.go for make fmt compatibility Jan 22, 2025
@moul moul mentioned this pull request Jan 22, 2025
2 tasks
@moul
Copy link
Member

moul commented Jan 22, 2025

Related with #3578

@jefft0
Copy link
Contributor

jefft0 commented Jan 23, 2025

@omarsy , can you add a description for this PR? The PR title has a lot of details. Maybe simplify the PR title and put details in the description.

gnovm/pkg/gnolang/internal/softfloat/gen/main.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/internal/softfloat/gen/main.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/internal/softfloat/gen/main.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/internal/softfloat/gen/main.go Outdated Show resolved Hide resolved
gnovm/pkg/gnolang/internal/softfloat/gen/main.go Outdated Show resolved Hide resolved
@thehowl thehowl changed the title fix(ci): replace copy.sh with Go generator for softfloat files and reorganize imports in runtime_softfloat64_test.go for make fmt compatibility fix(internal/softfloat): replace copy.sh with Go generator Jan 23, 2025
@thehowl thehowl changed the title fix(internal/softfloat): replace copy.sh with Go generator fix(gnovm/softfloat): replace copy.sh with Go generator Jan 23, 2025
@Gno2D2 Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 23, 2025
@thehowl
Copy link
Member

thehowl commented Jan 23, 2025

I think this could call gofumpt directly, actually, as we do in misc/genstd/genstd.go.

@omarsy omarsy force-pushed the fix/ci-soft-float branch from b97341a to 4ecec67 Compare January 27, 2025 21:44
@thehowl thehowl merged commit a885c78 into gnolang:master Jan 28, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Development

Successfully merging this pull request may close these issues.

5 participants