Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement DB backend using pebble k/v database. #3529

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ajnavarro
Copy link
Contributor

@ajnavarro ajnavarro commented Jan 16, 2025

Some benchmarks:

BenchmarkMemDBRandomReadsWrites-12    	 2050005	  619.0 ns/op	     129 B/op	       4 allocs/op
BenchmarkGoLevelDBRandomReadsWrites-12    303220	   4090 ns/op	     684 B/op	      13 allocs/op
BenchmarkPebbleDBRandomReadsWrites-12     258516	   6937 ns/op	      82 B/op	       3 allocs/op

BenchmarkMemlDBBatchWrites-12    	     2508206	  463.5 ns/op	     410 B/op	       3 allocs/op
BenchmarkGoLevelDBBatchWrites-12          925200       1517 ns/op       3255 B/op          2 allocs/op
BenchmarkPebbleDBBatchWrites-12    	     1934601	  649.0 ns/op	     121 B/op	       2 allocs/op

BenchmarkMemlDBIterator-12    	             705	2225342 ns/op	  746074 B/op	   10020 allocs/op
BenchmarkGoLevelDBIterator-12    	        1135	1146487 ns/op	   84513 B/op	   10014 allocs/op
BenchmarkPebbleDBIterator-12    	        2662	 409197 ns/op	     365 B/op	       5 allocs/op

Related issue: #1013

Signed-off-by: Antonio Navarro Perez <[email protected]>
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jan 16, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 16, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: ajnavarro/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
@thehowl
Copy link
Member

thehowl commented Jan 16, 2025

Did you manage to get results from supernova?

@Kouteki Kouteki added the in focus Core team is prioritizing this work label Jan 17, 2025
@Kouteki Kouteki added this to the 🚀 Mainnet beta launch milestone Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 10.32609% with 165 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tm2/pkg/db/pebbledb/pebbledb.go 15.07% 107 Missing ⚠️
tm2/pkg/db/internal/test_common.go 0.00% 58 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ajnavarro
Copy link
Contributor Author

Did you manage to get results from supernova?

I didn't have time yet but I'll try to test it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in focus Core team is prioritizing this work 📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants