feat(example): `r/mouss` #3472

mous1985 · 2025-01-09T21:15:11Z

Hi Gnomes ,
This is my home page. it was difficult to be creative 😅 , so i did what i can do

Home :

I put some informations about me

World kitchen :

I'm passionate about cooking, so I've set up a page for those who want to share their national culinary specialties or just their favorite recipes, since there are so many nationalities in gno community.

feel free to add your recipes ;)

@leohhhn

Gno2D2 · 2025-01-09T21:16:06Z

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)
The pull request description provides enough details (checked by @thehowl)

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: mous1985/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🔴 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission
The pull request description provides enough details
If
🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])
Can be checked by

team core-contributors

moul · 2025-01-09T22:11:21Z

examples/gno.land/r/mouss/home/home.gno

+}
+
+func renderHomepage(res *mux.ResponseWriter, req *mux.Request) {
+	var b bytes.Buffer


why are you using a bytes.Buffer?

Thanks for the feedback, i've updated the code,i use strings.Builder instead of bytes.Buffer it's more efficient for string concatenation. bytes.Buffer was just general purpose.
8f5cb186

moul · 2025-01-09T22:14:19Z

examples/gno.land/r/mouss/home/home.gno

+	if !isUser(caller) {
+		return config.ErrorUnauthorized
+	}
+	if contains(profile.Followers, addr) {


looks like you should use the freshly merged addrset library (#3448)

when i run gnodev

You need to run make install

@leohhhn
I did it , i get the same error

I realized I forgot to set the home_page branch to track master as its upstream so i haven't the p/moul/addrset in home_page branch . sorry 🙏🏽

moul · 2025-01-09T22:14:42Z

examples/gno.land/r/mouss/home/home.gno

+}
+
+func isUser(addr std.Address) bool {
+	return !isAuthorized(addr) && !contains(profile.Followers, addr)


shouldn't the if condition be checking the exacte opposite?

I use isUser to check if follower is not admin address or if the follower exist already in the list of followers. i still working on ,I think it's could be a good feature to follow and be followed by other users.

moul · 2025-01-09T22:15:09Z

examples/gno.land/r/mouss/home/home.gno

+}
+
+func writeRecipe(b *bytes.Buffer, recipe *Recipe) {
+	b.WriteString("## " + recipe.Name + "\n")


i think that you should consider using a ui library.

moul · 2025-01-09T22:15:53Z

examples/gno.land/r/mouss/home/home.gno

+	res.Write(b.String())
+}
+
+func writeRecipe(b *bytes.Buffer, recipe *Recipe) {


Suggested change

func writeRecipe(b *bytes.Buffer, recipe *Recipe) {

func (r Recipe) Render() string {

I also change writeProfile to (p Profile)Render
4959189b

func writeProfile to method (p Profile)Render

leohhhn

Thanks for the PR; check my comments and resolve them, and we can move forward :)

On top of this, I suggest you remove the string builder for rendering and simply add a var out string

examples/gno.land/r/mouss/config/config.gno

leohhhn · 2025-01-21T10:35:03Z

examples/gno.land/r/mouss/config/config.gno

+func Backup() std.Address {
+	return backup
+}
+func SetBack(buAddress std.Address) error {


Why not SetBackup(newAddr std.Addr) error?

leohhhn · 2025-01-21T10:36:20Z

examples/gno.land/r/mouss/config/config_test.gno

@@ -0,0 +1 @@
+package config


Write some simple tests please :)

examples/gno.land/r/mouss/home/home.gno

leohhhn · 2025-01-21T11:04:21Z

examples/gno.land/r/mouss/home/home.gno

+}
+func writeNavigation(b *strings.Builder) {
+	navItems := []string{
+		md.Link("Home", ""),
+		md.Link("World Kitchen", Rec),
+		md.Link("Hackerspace", "https://github.com/gnolang/hackerspace/issues/86#issuecomment-2535795751"),
+	}
+	b.WriteString(strings.Join(navItems, " | ") + "\n\n" + md.HorizontalRule() + "\n\n")
+}
+func Render(path string) string {
+	return router.Render(path)
+}
+func writeGnoArt(b *strings.Builder) {


Same as above, please make sure you have newlines.

🙏🏽 sorry 27a0b5d1

leohhhn · 2025-01-21T11:05:19Z

examples/gno.land/r/mouss/home/home.gno

+	b.WriteString("```\n")
+	for _, line := range []string{
+		"      -==++.                                                                  ",
+		"     *@@@@=                                     @-                          -@",
+		"    #@@@@@:       -==-.-- :-::===:   .-++-.     @-   .===:.- .-.-==-   .===:=@",
+		"   #@@@@@@@:    -@@%**%@@ #@@#*#@@- *@@**@@*    @-  +%=::-*@ +@=-:-@* +%=::-*@",
+		"  +@%#**#%@@    %@+   :@@ *@+   #@=+@%    %@+   @= :@:    -@ +%    +%.@:    -@",
+		"  -:       -    *@%:..+@@ *@+   #@=-@@:  :@@=   @- .@=    =@ +@    *%.@=    =@",
+		"  --:==+=-:=.    =%@%#*@@ *@+   #@+ =%@%%@%= #* %#=.:%*===*@ +%    +% -%*===*@",
+		"  -++++=++++.    =-:::*@#  .     .    .::.   ..  ::   .::  .  .         .::  .",
+		"   .-=+++=:     .*###%#=                                                      ",
+		"      ::                                                                      ",
+	} {
+		b.WriteString(line + "\n")
+	}
+	b.WriteString("```\n------")


Why not write this as a single const string?

I add it in the first commit

leohhhn · 2025-01-21T11:05:42Z

examples/gno.land/r/mouss/home/home.gno

Would be nice to have a bit of tests for this home package.

Co-authored-by: Leon Hudak <[email protected]>

leohhhn · 2025-01-21T23:34:43Z

examples/gno.land/r/mouss/home/home.gno

+
+// init initializes the router with the homepage and recipe routes.
+func init() {
+


sorry about that, I'll be careful in the future to provide a clean code.
68b6a02a

leohhhn · 2025-01-21T23:35:06Z

examples/gno.land/r/mouss/home/home_test.gno

+}
+
+func TestFollow(t *testing.T) {
+


Random newline

I made a single commit for all random new lines in home_test.gno
e584e454

leohhhn · 2025-01-21T23:35:11Z

examples/gno.land/r/mouss/home/home_test.gno

+}
+
+func TestIsUser(t *testing.T) {
+


Random newline

leohhhn · 2025-01-21T23:35:14Z

examples/gno.land/r/mouss/home/home_test.gno

+}
+
+func TestIsAuthorized(t *testing.T) {
+


Random newline

leohhhn · 2025-01-21T23:35:18Z

examples/gno.land/r/mouss/home/home_test.gno

+)
+
+func TestProfile(t *testing.T) {
+


Random newline

leohhhn · 2025-01-21T23:35:53Z

examples/gno.land/r/mouss/home/home.gno

+// TODO:any user can follow and to be followed by any other user
+// TODO: add a function to unfollow


I suggest you fix these TODOs before we can merge

I added func Unfollow d9f02e1e .

For // TODO: add a function to unfollow
In my case, my profile is the only one on my home page, so no one else can create their profile there. What I’d like to propose for a future version, or for all home pages, is to have a template with commonly used features. for example: config, home, social, and within social, we include all the features related to user (home page) such like like, follow , unfollow , comment, subscribe ...etc.

jefft0 · 2025-01-22T15:19:41Z

Removed the review/triage-pending label because this PR was reviewed by core dev moul.

github-actions bot assigned mous1985 Jan 9, 2025

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jan 9, 2025

mous1985 changed the title ~~Home page~~ feat: Home page Jan 9, 2025

moul reviewed Jan 9, 2025

View reviewed changes

mous1985 changed the title ~~feat: Home page~~ feat(example): r/mouss Jan 10, 2025

mous1985 force-pushed the home_page branch from e49d916 to 86c8512 Compare January 10, 2025 12:46

mous1985 added 11 commits January 10, 2025 18:29

first commit

b55e295

fix: import

4cc7820

simple home-page

51f75c6

add follower

ac0c168

add recipe to my homepage

2d47ee0

refactor v0 of home page

05d0853

refactor: replace bytes.Buffer with strings.builder

918c773

refactor: use p/moul/addrset

844a61c

ref: add p/moul/md

b5e2868

doc

f64569a

ref: func writeRecipe to method (r Recipe)Render

4959189

func writeProfile to method (p Profile)Render

mous1985 force-pushed the home_page branch from 86c8512 to 4959189 Compare January 10, 2025 18:28

mous1985 mentioned this pull request Jan 14, 2025

mous1985 Builder Journey gnolang/hackerspace#86

Open

thehowl requested a review from leohhhn January 16, 2025 15:00

leohhhn requested changes Jan 21, 2025

View reviewed changes

mous1985 added 2 commits January 21, 2025 13:30

Merge remote-tracking branch 'upstream/master' into home_page

91845a6

ref: replace strings.Builder by var out string

cdbd8de

Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 21, 2025

mous1985 and others added 4 commits January 21, 2025 15:20

Update examples/gno.land/r/mouss/config/config.gno

48795c4

Co-authored-by: Leon Hudak <[email protected]>

ref : SetBackup(newAddress std.Address)

91baa9c

test: add config_test.gno

e7f2e73

Update examples/gno.land/r/mouss/home/home.gno

bb096ac

Co-authored-by: Leon Hudak <[email protected]>

mous1985 and others added 4 commits January 21, 2025 15:45

Update examples/gno.land/r/mouss/home/home.gno

b62f386

Co-authored-by: Leon Hudak <[email protected]>

Update examples/gno.land/r/mouss/home/home.gno

933f759

Co-authored-by: Leon Hudak <[email protected]>

ref: add new line between func

27a0b5d

test: add home_test.gno

2caabf7

leohhhn removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 21, 2025

leohhhn reviewed Jan 21, 2025

View reviewed changes

Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 21, 2025

leohhhn reviewed Jan 21, 2025

View reviewed changes

mous1985 added 7 commits January 22, 2025 10:15

ref: randomnew line in home.gno

68b6a02

ref: random new line in home_test.gno

e584e45

feat: add unfollow function

d9f02e1

fix: ci

0586b1b

fix: ci

aafaf5e

fix: ci

7874d67

fix: ci

7d1e347

jefft0 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 22, 2025

Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 22, 2025

jefft0 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 24, 2025

Gno2D2 requested a review from a team January 24, 2025 15:47

	func writeRecipe(b bytes.Buffer, recipe Recipe) {
	func (r Recipe) Render() string {


		// init initializes the router with the homepage and recipe routes.
		func init() {

		// TODO:any user can follow and to be followed by any other user
		// TODO: add a function to unfollow

feat(example): r/mouss #3472

Are you sure you want to change the base?

feat(example): r/mouss #3472

Conversation

mous1985 commented Jan 9, 2025

Home :

World kitchen :

Gno2D2 commented Jan 9, 2025 • edited Loading

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Can be checked by

If

Can be checked by

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mous1985 Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mous1985 Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leohhhn left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mous1985 Jan 22, 2025 • edited Loading

Choose a reason for hiding this comment

jefft0 commented Jan 22, 2025

feat(example): `r/mouss` #3472

feat(example): `r/mouss` #3472

Gno2D2 commented Jan 9, 2025 •

edited

Loading

mous1985 Jan 10, 2025 •

edited

Loading

mous1985 Jan 10, 2025 •

edited

Loading

leohhhn left a comment •

edited

Loading

mous1985 Jan 22, 2025 •

edited

Loading