Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): handle empty args by assuming current directory for gno test #3429

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Nemanya8
Copy link
Contributor

This PR addresses Issue #3420 by improving the gno test command. It now assumes the current directory (.) as the default path when no directory is specified, similar to go test.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Dec 30, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 30, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: Nemanya8/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)

Can be checked by

  • team core-contributors

@Nemanya8
Copy link
Contributor Author

The test case for no arguments currently fails, which is expected due to the changes. However, if we are moving forward with this merge, the test case should be updated accordingly. Please let me know if you'd like me to handle the update.

@notJoon notJoon added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 31, 2024
@notJoon
Copy link
Member

notJoon commented Dec 31, 2024

the test case should be updated accordingly. Please let me know if you'd like me to handle the update.

I confirmed that it runs well when executed locally. It seems we need to make the CI pass, so could you modify the tests if possible?

@Nemanya8
Copy link
Contributor Author

so could you modify the tests if possible?

Could you guide me on modifying the tests? Should I only adjust the test with no arguments, or should I add a variation without path arguments for each test? The latter approach is more thorough, but it would basically double the testing time.

Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need some unit or integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related review/triage-pending PRs opened by external contributors that are waiting for the 1st review
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

4 participants