-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test): handle empty args by assuming current directory for gno test #3429
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
The test case for no arguments currently fails, which is expected due to the changes. However, if we are moving forward with this merge, the test case should be updated accordingly. Please let me know if you'd like me to handle the update. |
I confirmed that it runs well when executed locally. It seems we need to make the CI pass, so could you modify the tests if possible? |
Could you guide me on modifying the tests? Should I only adjust the test with no arguments, or should I add a variation without path arguments for each test? The latter approach is more thorough, but it would basically double the testing time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need some unit or integration tests.
This PR addresses Issue #3420 by improving the gno test command. It now assumes the current directory (.) as the default path when no directory is specified, similar to go test.