Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): Ivan's registry, home realm #3354

Merged
merged 31 commits into from
Jan 14, 2025
Merged

Conversation

Ursulovic
Copy link
Contributor

Created registry for further development of realms, finalising home realm.

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 17, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 17, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details (checked by @thehowl)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: Ursulovic/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

@leohhhn
Copy link
Contributor

leohhhn commented Dec 17, 2024

When creating a PR, create it as Draft first 🙏

@leohhhn leohhhn marked this pull request as draft December 17, 2024 16:01
@leohhhn leohhhn changed the title Created registry, home real in progress feat(): Ivan's registry, home realm Dec 17, 2024
@leohhhn leohhhn changed the title feat(): Ivan's registry, home realm feat(examples): Ivan's registry, home realm Dec 17, 2024
@leohhhn
Copy link
Contributor

leohhhn commented Dec 17, 2024

Also you say finalizing, but your home realm package is empty 👀

Ivan Ursulovic added 2 commits December 18, 2024 03:34
@Ursulovic
Copy link
Contributor Author

Thank you @moul, I have implemented all your suggestions!

Also you say finalizing, but your home realm package is empty 👀

Sorry, I forgot to stage the files earlier :/. I’ve added them now. I have created the Realm package, which primarily displays random blockchain "wisdom" and provides some information about me. Tomorrow, I plan to implement functionality of modifying the realm data if authorization is passed using my registry realm.

@thehowl thehowl requested a review from leohhhn December 18, 2024 11:50
@Ursulovic Ursulovic marked this pull request as ready for review December 20, 2024 16:18
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.

While this is good work, I suggest you try to be a bit more creative with your home realm.

PRs in the monorepo/examples should be a good example and unique to newcomers. While this is good code, if you take a look the home realms of other people, this matches some things we have already seen.

Please, try to find some interesting example realm, or make something completely new which can be imported into your realm to make it more unique.

If you do not do this and want to keep your home realm like this, you can simply deploy it permissionlessly with gnokey or Adena.

@Ursulovic
Copy link
Contributor Author

Thank you for the update @leohhhn, I will think of new Home Realm idea and write new version soon!

Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; please check the comments and we can merge 🙏

examples/gno.land/r/ursulovic/home/home.gno Outdated Show resolved Hide resolved
examples/gno.land/r/ursulovic/home/home.gno Outdated Show resolved Hide resolved
examples/gno.land/r/ursulovic/home/home.gno Outdated Show resolved Hide resolved
examples/gno.land/r/ursulovic/home/home.gno Outdated Show resolved Hide resolved
Ivan Ursulovic and others added 3 commits January 13, 2025 17:41
@leohhhn
Copy link
Contributor

leohhhn commented Jan 13, 2025

Seems that some code is still not properly formatted; as pointed out by the CI; you can run make fmt defined in the examples/Makefile. This will recusrively run gno fmt on all code in the folder.

@Ursulovic
Copy link
Contributor Author

Seems that some code is still not properly formatted; as pointed out by the CI; you can run make fmt defined in the examples/Makefile. This will recusrively run gno fmt on all code in the folder.

Fixed formatting issues on this commit : 706784e

Ursulovic and others added 2 commits January 14, 2025 22:08
…tURLValidation function. Now isValidURL is initialised to defaultURLValidation in constructor instead of it being initialised in initIsValidUrl function
@Ursulovic Ursulovic requested a review from leohhhn January 14, 2025 21:28
Ivan Ursulovic added 2 commits January 14, 2025 22:42
… I have created new variable studioConnectUrl which stores studio connect url to this home realm and UpdateStudioConnectUrl function which allows owner to update studioConnectUrl. studioConnectUrl is now set to http://google.com since realm is not deployed yet, but when it is I will call UpdateStudioConnectUrl function to set a proper url.
…ble struct functions can be called from the outside
@Ursulovic Ursulovic requested a review from leohhhn January 14, 2025 21:51
@Ursulovic Ursulovic requested a review from leohhhn January 14, 2025 22:11
@leohhhn leohhhn merged commit bd1d104 into gnolang:master Jan 14, 2025
12 checks passed
@Ursulovic Ursulovic deleted the home-page branch January 14, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Development

Successfully merging this pull request may close these issues.

5 participants