-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): Ivan's registry, home realm #3354
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
When creating a PR, create it as Draft first 🙏 |
Also you say finalizing, but your home realm package is empty 👀 |
…es such as updating home page data
I was few commits behind before pushing
Thank you @moul, I have implemented all your suggestions!
Sorry, I forgot to stage the files earlier :/. I’ve added them now. I have created the Realm package, which primarily displays random blockchain "wisdom" and provides some information about me. Tomorrow, I plan to implement functionality of modifying the realm data if authorization is passed using my registry realm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR.
While this is good work, I suggest you try to be a bit more creative with your home realm.
PRs in the monorepo/examples
should be a good example and unique to newcomers. While this is good code, if you take a look the home realms of other people, this matches some things we have already seen.
Please, try to find some interesting example realm, or make something completely new which can be imported into your realm to make it more unique.
If you do not do this and want to keep your home realm like this, you can simply deploy it permissionlessly with gnokey
or Adena.
Thank you for the update @leohhhn, I will think of new Home Realm idea and write new version soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; please check the comments and we can merge 🙏
Had to manually fix inconsistent spasing
Seems that some code is still not properly formatted; as pointed out by the CI; you can run |
Fixed formatting issues on this commit : 706784e |
…tURLValidation function. Now isValidURL is initialised to defaultURLValidation in constructor instead of it being initialised in initIsValidUrl function
… I have created new variable studioConnectUrl which stores studio connect url to this home realm and UpdateStudioConnectUrl function which allows owner to update studioConnectUrl. studioConnectUrl is now set to http://google.com since realm is not deployed yet, but when it is I will call UpdateStudioConnectUrl function to set a proper url.
…ble struct functions can be called from the outside
…that I think would be correct
Created registry for further development of realms, finalising home realm.