Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add p/moul/realmpath #3094

Merged
merged 5 commits into from
Nov 12, 2024
Merged

feat: add p/moul/realmpath #3094

merged 5 commits into from
Nov 12, 2024

Conversation

moul
Copy link
Member

@moul moul commented Nov 8, 2024

Lightweight Render.path parsing and link generation library with an idiomatic API, closely resembling that of net/url.

@moul moul self-assigned this Nov 8, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.75%. Comparing base (4f27a57) to head (3e74dbf).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3094      +/-   ##
==========================================
- Coverage   63.77%   63.75%   -0.03%     
==========================================
  Files         548      548              
  Lines       78681    78681              
==========================================
- Hits        50180    50161      -19     
- Misses      25117    25136      +19     
  Partials     3384     3384              
Flag Coverage Δ
contribs/gnodev 60.54% <ø> (ø)
contribs/gnofaucet 14.82% <ø> (ø)
gno.land 73.62% <ø> (ø)
gnovm 67.92% <ø> (ø)
misc/genstd 79.72% <ø> (ø)
tm2 62.38% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
@moul moul marked this pull request as ready for review November 8, 2024 20:06
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Just wondering about the name, but can't think of a better one right now. I'll let you know if I get a better idea.

@leohhhn leohhhn merged commit 5f85d50 into gnolang:master Nov 12, 2024
134 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants