fix(gnovm): improve error message for nil assignment in variable decl… #3068
+177
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3068 +/- ##
=======================================
Coverage 63.33% 63.34%
=======================================
Files 548 548
Lines 78599 78599
=======================================
+ Hits 49784 49791 +7
+ Misses 25461 25454 -7
Partials 3354 3354
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
omarsy
force-pushed
the
fix/improve-nil-not-assignable
branch
from
f8443e5
to
a67d677
Compare
omarsy
commented
Nov 4, 2024
gnovm/tests/files/assign29.gno
Outdated
| } | ||
|
|
||
| // Error: | ||
| // main/files/assign29.gno:5:2: cannot use nil as int value in variable declaration |
There was a problem hiding this comment.
should be cannot use nil as int value in assignment
ltzmaxwell
reviewed
Nov 5, 2024
gnovm/pkg/gnolang/type_check.go
Outdated
| @@ -289,7 +289,7 @@ func checkAssignableTo(xt, dt Type, autoNative bool) error { | |||
| // case0 | |||
| if xt == nil { // see test/files/types/eql_0f18 | |||
| if !maybeNil(dt) { | |||
| panic(fmt.Sprintf("invalid operation, nil can not be compared to %v", dt)) | |||
| panic(fmt.Sprintf("cannot use nil as %v value in variable declaration", dt)) | |||
There was a problem hiding this comment.
thank you for tackling this.
|
can you add some more tests like |
omarsy
force-pushed
the
fix/improve-nil-not-assignable
branch
from
3cec7e2
to
5b171a4
Compare
omarsy
force-pushed
the
fix/improve-nil-not-assignable
branch
from
5b171a4
to
6be8a9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aration
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description