-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: invoke user recover with implicit panics #3067
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3067 +/- ##
==========================================
- Coverage 63.77% 63.74% -0.04%
==========================================
Files 548 548
Lines 78681 78773 +92
==========================================
+ Hits 50180 50215 +35
- Misses 25117 25164 +47
- Partials 3384 3394 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
can you please add some tests for this? |
I tried a fix similar to this one: #2484, but my approach wasn't preferred. They favor an indiscriminate runtime panic, which complicates things for me (it is possible, but need a refactoring). I see two options:
|
its still WIP |
5b8936f
to
ce6141c
Compare
tests added |
Currently only explicit panic invocations are recovered in the user code.
This PR covers the implicit panics that happen because of invalid operations.
Associated issue
This maintains the distinction between VM panics and user panics.
Here is a list of possible runtime panics that we will cover.