fix: global var dependencies

[petar-dambovaliev]

fixes this by adding missing logic in in findUndefined2

[codecov]

Codecov Report

Attention: Patch coverage is 53.01455% with 226 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
gnovm/pkg/gnolang/preprocess.go	53.01%	209 Missing and 17 partials ⚠️

📢 Thoughts on this report? Let us know!

[zivkovicmilos]

Left some nitty comments 🙏

Overall looks good, thank you for the fix 🙏

[thehowl]

Please also add more tests to check for different cases, thanks!

outdated

[Kouteki]

@petar-dambovaliev I've moved this PR to draft until it's ready for review.

[petar-dambovaliev]

Only codecov failing. Its ready. @Kouteki

[ltzmaxwell]

LGTM! A few requests, mostly regarding comments, so we can avoid reviewing this as a brand new PR each time. :)

[ltzmaxwell]

and what we do with the codecov? @petar-dambovaliev @zivkovicmilos

[ltzmaxwell]

Perhaps the logic in findUndefined2SkipLocals could be simplified further by modifying it to only find the name without type (which would imply that the predefined name is enough). In that case, GetDeclForSafe would no longer be necessary, correct?

[ltzmaxwell]

Perhaps the logic in findUndefined2SkipLocals could be simplified further by modifying it to only find the name without type (which would imply that the predefined name is enough). In that case, GetDeclForSafe would no longer be necessary, correct?

maybe the difference won't be big, just some food for thoughts.

[petar-dambovaliev]

Perhaps the logic in findUndefined2SkipLocals could be simplified further by modifying it to only find the name without type (which would imply that the predefined name is enough). In that case, GetDeclForSafe would no longer be necessary, correct?

maybe the difference won't be big, just some food for thoughts.

At first, i tried having a single function but it became too many changes and too messy

[Kouteki]

and what we do with the codecov? @petar-dambovaliev @zivkovicmilos

It's not ideal, but codecov for this PR is not a blocker. We can merge this.