Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert compatible types #2014

Closed
wants to merge 6 commits into from
Closed

Conversation

deelawn
Copy link
Contributor

@deelawn deelawn commented May 1, 2024

Closes #2006.

This PR ensures that the types returned or assigned are converted the the type that is expected.

I don't 100% understand the reason for excluding native and uverse types from being considered for conversion. If anyone has an example that would break this, please include it in a comment.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.38%. Comparing base (5429655) to head (9ac3052).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2014      +/-   ##
==========================================
+ Coverage   46.69%   48.38%   +1.69%     
==========================================
  Files         492      409      -83     
  Lines       69700    62043    -7657     
==========================================
- Hits        32546    30022    -2524     
+ Misses      34442    29519    -4923     
+ Partials     2712     2502     -210     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deelawn deelawn marked this pull request as ready for review May 1, 2024 19:35
@deelawn deelawn requested review from jaekwon, piux2, thehowl and moul as code owners May 1, 2024 19:35
@deelawn deelawn requested a review from petar-dambovaliev May 1, 2024 19:42
@piux2
Copy link
Contributor

piux2 commented May 1, 2024

this PR #1246 fixed it

@deelawn
Copy link
Contributor Author

deelawn commented May 1, 2024

Closing in favor of #1246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Clarify custom types support
2 participants