docs(vim-lsp): enable buildOnSave option #1382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to me that enabling this option gives better error detection.
For example, this code returns no diagnostics (errors in LSP lexic) if
buildOnSave is false:
```
package main
func main() {
xxx
}
```
While the `undefined: xxx` is part of the diagnostics when buildOnSave
is true.
thehowl
reviewed
Nov 20, 2023
There was a problem hiding this comment.
This will stop working after #1297.
I think we should defer this either until jdkato comes back & starts merging the related PR work we're carrying on https://github.com/gno-playground/gnols, or we should fork, apply our patches and change buildOnSave, then merge this PR
|
Drafting until upstream Gnols is figured out in this regard. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling this option gives better error detection.
For example, this code returns no diagnostics (errors in LSP lexic) if buildOnSave is false:
While the
undefined: xxxis part of the diagnostics when buildOnSave is true.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description