Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlibs): hash/crc32 #1372

Closed
wants to merge 5 commits into from
Closed

feat(stdlibs): hash/crc32 #1372

wants to merge 5 commits into from

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Nov 14, 2023

WIP

Memo: Currently, gno does not have a cpu package, so the like SSE4.2 instruction set that is important for hardware acceleration is not available. But this may not a matter.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1a53c0) 55.91% compared to head (79746f4) 55.90%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
- Coverage   55.91%   55.90%   -0.01%     
==========================================
  Files         420      420              
  Lines       65415    65415              
==========================================
- Hits        36578    36573       -5     
- Misses      25977    25979       +2     
- Partials     2860     2863       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notJoon notJoon closed this Dec 6, 2023
@notJoon notJoon deleted the crc32 branch December 6, 2023 10:47
@thehowl
Copy link
Member

thehowl commented Dec 7, 2023

@notJoon is there a reason for closing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants