-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve Docusaurus build #1351
Conversation
✅ Deploy Preview for gno-docs2 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1351 +/- ##
==========================================
- Coverage 55.96% 55.95% -0.02%
==========================================
Files 420 420
Lines 65415 65415
==========================================
- Hits 36612 36603 -9
- Misses 25948 25956 +8
- Partials 2855 2856 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just nits
Co-authored-by: Danny <[email protected]>
Co-authored-by: Danny <[email protected]>
…milos/gno into hotfix/docusaurus-build
|
||
- name: Install Docusaurus Dependencies | ||
run: | | ||
cd misc/docusaurus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi, we can set the working_directory
## Description This PR fixes dangling HTML tags in the Docusaurus config, as well as introduces a workflow file that will make sure the Docusaurus documentation is built correctly <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Danny <[email protected]>
Description
This PR fixes dangling HTML tags in the Docusaurus config, as well as introduces a workflow file that will make sure the Docusaurus documentation is built correctly
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description