Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): remove unused func parseBalance #1344

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

harry-hov
Copy link
Contributor

Currently CI is complaining about unused func parseBalance. Fixed it.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@harry-hov harry-hov requested a review from moul November 8, 2023 09:02
@harry-hov harry-hov requested a review from a team as a code owner November 8, 2023 09:02
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11f4359) 55.88% compared to head (4394ac8) 55.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
- Coverage   55.88%   55.87%   -0.02%     
==========================================
  Files         420      420              
  Lines       65384    65373      -11     
==========================================
- Hits        36539    36524      -15     
- Misses      25986    25990       +4     
  Partials     2859     2859              
Files Coverage Δ
gno.land/pkg/gnoland/app.go 0.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl merged commit 678686a into gnolang:master Nov 8, 2023
180 checks passed
moul pushed a commit to moul/gno that referenced this pull request Nov 14, 2023
Currently CI is complaining about unused func `parseBalance`. Fixed it. 

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants