Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(fix): tidy remaining gno.mod files #1338

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

harry-hov
Copy link
Contributor

@harry-hov harry-hov commented Nov 6, 2023

CI failing after merging #1035
Seems like some mod files are not tidy.

PS: Good part is we get to know that CI for mod files is working as expected :p

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@harry-hov harry-hov requested a review from a team as a code owner November 6, 2023 16:57
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4749369) 47.98% compared to head (4a55f6a) 48.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
+ Coverage   47.98%   48.00%   +0.01%     
==========================================
  Files         372      372              
  Lines       63091    63091              
==========================================
+ Hits        30277    30288      +11     
+ Misses      30352    30346       -6     
+ Partials     2462     2457       -5     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harry-hov harry-hov requested a review from moul November 6, 2023 17:40
@harry-hov harry-hov merged commit 4c7f93c into gnolang:master Nov 6, 2023
176 checks passed
gfanton pushed a commit to gfanton/gno that referenced this pull request Nov 9, 2023
CI failing after merging gnolang#1035 
Seems like some mod files are not tidy.
moul pushed a commit to moul/gno that referenced this pull request Nov 14, 2023
CI failing after merging gnolang#1035 
Seems like some mod files are not tidy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants