Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use coverpkg for accurate reporting of pkg/gnolang #1220

Closed
wants to merge 1 commit into from

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Oct 10, 2023

Supersedes #1122

@thehowl thehowl requested a review from a team as a code owner October 10, 2023 23:04
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fa8eb77) 47.84% compared to head (c62a1be) 47.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
- Coverage   47.84%   47.31%   -0.54%     
==========================================
  Files         369      367       -2     
  Lines       62710    61519    -1191     
==========================================
- Hits        30005    29109     -896     
+ Misses      30282    30041     -241     
+ Partials     2423     2369      -54     

see 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl marked this pull request as draft October 11, 2023 01:22
@thehowl
Copy link
Member Author

thehowl commented Oct 11, 2023

marking as draft until the CI is fixed

@thehowl
Copy link
Member Author

thehowl commented Mar 26, 2024

current state: this PR fails the CI because running the tests with coverpkg makes them time out.

Arguably, this is something we might not even want, as we want to transition to testing pkg/gnolang with unit tests, and using these "integration tests" as a supporting feature rather than one which actually determines converage.

Closing, together with #1122, if there is a case for putting this back in do raise it in an issue/reopen one of the PRs.

@thehowl thehowl closed this Mar 26, 2024
@thehowl thehowl deleted the dev/morgan/coverpkg branch November 8, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🌟 Wanted for Launch
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant