Fix CarpetClient not disconnecting when leaving multiplayer #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doesn't seem to be called, and the MinecraftClient one should be enough
|
People are always asking me about this crash; FYI . |
Heitzenberg
added a commit
to Heitzenberg/fabric-carpet
that referenced
this pull request
Aug 13, 2024
Resolved conflicts with ClientCommonPacketListenerImpl_customPacketMixin.java - Deleted the file as it was removed in the pull request - Merged changes from MinecraftMixin.java and carpet.mixins.json
|
@gnembon Any chance this could be integrated? It's highly annoying to have carpet crash Minecraft each time you switch to a local world. :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1908.
The issue was that the new transfer packets changed the signature of the disconnect method, but left a shortcut with the old one, that is no longer called when disconnecting. This should also make Carpet work properly when the client is being transferred between Carpet/non-Carpet servers (or just with different rules).
This removes the
ClientCommonPacketListenerImplmixin given it seems to not do anything anymore, and it was added with the network refactor.