Fix fake players using wrong reach values #1883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bots still have a 4.5 block range while interacting with blocks, but entity interaction range has been reduced to 3 blocks, fixing gnembon#1882 Player attacking is more realistic now. Using /player <player> attack once will swing even while not targeting an entity, and will properly reset attack cooldown gnembon#1881 is also fixed, as players will properly lower their movement speed while using slow items
altrisi
reviewed
Apr 28, 2024
| if (player.isUsingItem()) | ||
| { | ||
| ItemStack item = player.getUseItem(); | ||
| ((ServerPlayerInterface) player).getActionPack().setSlowed(item.isEdible() || item.is(Items.SHIELD) || item.is(Items.BRUSH) || item.is(Items.BOW) || item.is(Items.CROSSBOW) || item.is(Items.TRIDENT) || item.is(Items.GOAT_HORN) || item.is(Items.SPYGLASS)); |
There was a problem hiding this comment.
Isn't there an equivalent method for wherever vanilla does this, maybe just isUsingItem (tho I may be missing some)? Or is that client only?
Also given nothing else is using slowed, it could be a local.
Haven't checked more of the code yet, sorry.
There was a problem hiding this comment.
Yep, looks like player.isUsingItem() is only true while using any of those listed items, most of that was completely unneeded. I'll commit a cleaned up version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bots still have a 4.5 block range while interacting with blocks, but entity interaction range has been reduced to 3 blocks, fixing #1882
Player attacking is more realistic now. Using /player attack once will swing even while not targeting an entity, and will properly reset attack cooldown
#1881 is also fixed, as players will properly lower their movement speed while using slow items