Acl 1.5.0 #123
Merged
Acl 1.5.0 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, the changes should make adding the request of #112 fairly straight forward with the function mappings to each API request. |
|
Hi. Why did this merge break the Travis tests? Can I pull the repository from master still? Or should I take a previous commit? Thanks ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I saw not too long ago that your consul client was missing the new Consul's ACL API. So I went ahead and wrote out the update mostly for work.
Anyway, here's a patch for adding the updated Consul ACL for roles, policies, and tokens. I haven't gone ahead and added the auth portion of the new Consul's ACL yet, but believe the patch is in well enough shape to warrant a PR. I have left the patch unsquashed for easier review. Once you believe the PR is deemed ready, I'll go ahead rebase and squash the changes.