Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts needed to reproduce results in the NE/RE report #210

Merged
merged 5 commits into from
Jul 24, 2023

Conversation

radhakrishnatg
Copy link
Contributor

Addresses issue:

Summary/Motivation:

This PR adds scripts needed to reproduce results in the NE-RE combined report. The scripts are located in a folder called report in the nuclear_case folder.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Jul 10, 2023
@lbianchi-lbl
Copy link
Contributor

lbianchi-lbl commented Jul 10, 2023

@radhakrishnatg the failures in the "Notebooks checks" jobs seem to be related to our pytest plugin. I'm not sure what's happening but I'll look into it.

UPDATE: fixed by #212.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (654d287) 89.87% compared to head (bfb095d) 89.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          77       77           
  Lines        9257     9257           
=======================================
  Hits         8320     8320           
  Misses        937      937           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ksbeattie ksbeattie added the Final Report Code to reproduce case studies in final reports label Jul 17, 2023
dguittet
dguittet previously approved these changes Jul 18, 2023
Copy link
Contributor

@dguittet dguittet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to run everything

Copy link
Contributor

@esrawli esrawli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All models run and solved with the expected behavior

@dguittet dguittet self-requested a review July 24, 2023 16:52
@ksbeattie ksbeattie enabled auto-merge (squash) July 24, 2023 17:02
@ksbeattie ksbeattie merged commit e0b8192 into gmlc-dispatches:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final Report Code to reproduce case studies in final reports Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants