New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove strictly parsnip tests #17

Open

topepo wants to merge 1 commit into gmcmacran:main from topepo:main

topepo commented Feb 10, 2025

We'll be submitting a new version of parsnip to CRAN this week. One change is how we handle NULL engines (tidymodels/parsnip#1248)

When checking reverse dependencies, tidydann showed some test failures. The tests in question don't really test any of the code within tidydann:

test_that("bad input", {
  expect_error(nearest_neighbor_adaptive(mode = "reallyunknown"))
  expect_error(nearest_neighbor_adaptive() |> set_engine(NULL))
})

so this PR removes them.


          remove strictly parsnip tests

8df25da

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet