Enable build on 32bit architectures #202
Closed
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I honestly never really considered 32 bit machines, so I tried cross-compilation to i686. The provided patch does fix the compilation, but unit testing fails. Only one failure, which is much less than I feared, but still, it begs the question of the value to fix it. Are there any known users of Jellyfish on 32-bit architecture? Given the circumstances, I would rather stop building for 32-bit architecture. |
|
I don't have architecture-specific details, and I'm happy to drop 32-bit builds from our side. (Bio)Conda isn't building for 32-bit systems, for example |
|
So let's drop 32-bit systems. I'll update the README. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been carrying this patch in Debian since 2020. Optionally we can stop building for 32-bit architectures, which I find reasonable for bioinformatic software.