Fix: use unsigned value to represent bytes #4493
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The forcing of signed char type was introduced by 3fb3bb5d38r, "configure: force 'char' type to be signed (gluster#4025)". Thus at xlators/cluster/afr/src/afr-inode-write.c was found the use of a char type to represent bytes, when it should be using an unsigned type to avoid sign extension and overflow. This commit changes the variable "byte" to "unsigned" type. Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
The forcing of signed char type was introduced by 3fb3bb5d38r, "configure: force 'char' type to be signed (gluster#4025)". Thus at xlators/features/compress/src/cdc-helper.c was found the use of a char type to represent bytes, when it should be using an unsigned type to avoid sign extension and overflow. This commit changes the variable "gzip_header" to "unsigned" type. Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
CLANG-FORMAT FAILURE: index ec2ba9878..0f9d806b1 100644
--- a/xlators/features/compress/src/cdc-helper.c
+++ b/xlators/features/compress/src/cdc-helper.c
@@ -30,8 +30,8 @@
* gzip_header is added only during debugging.
* Refer to the function cdc_dump_iovec_to_disk
*/
-static const unsigned char gzip_header[10] = {'\037', '\213', Z_DEFLATED, 0, 0, 0, 0,
- 0, 0, GF_CDC_OS_ID};
+static const unsigned char gzip_header[10] = {
+ '\037', '\213', Z_DEFLATED, 0, 0, 0, 0, 0, 0, GF_CDC_OS_ID};
static int32_t
cdc_next_iovec(cdc_info_t *ci) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some variables that represent bytes were found using a signed char type.
Before 3fb3bb5d38r, "configure: force 'char' type to be signed (#4025),
char types could be unsigned, depending on the platform, but now thery are signed.
This intoduces a rough edge on variables that relied on the "unsignedness" of the type char to represent bytes, without actually enforcing it.
This PR addresses that by enforcing the use of "unsigned" type in those cases.