This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
brick-mux : fix spurious socket connect failure issue during volume stop #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the logic of using the parent socket file to send the detach request by picking it up from /proc/<pid>/cmdline where pid is the process id of the parent brick. During Multiplex, this would avoid creating a hard link of a socket file. Credits : [email protected] for helping with the utility function Fixes: gluster#1468 Signed-off-by: Atin Mukherjee <[email protected]>
ghost
assigned
added 2 commits
January 8, 2019 20:36
Signed-off-by: Atin Mukherjee <[email protected]>
Signed-off-by: Atin Mukherjee <[email protected]>
|
retest this please |
1 similar comment
|
retest this please |
Fix error handling from ReadFromPidFile call. Also added a check to bypass detach if the brick pid is -1. Signed-off-by: Atin Mukherjee <[email protected]>
atinmu
force-pushed
the
vol-stop-socket-connect
branch
from
bb1ba6b
to
cedf0cb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the logic of using the parent socket file to send the detach
request by picking it up from /proc//cmdline where pid is the
process id of the parent brick. During Multiplex, this would avoid
creating a hard link of a socket file.
Credits : [email protected] for helping with the utility function
Fixes: #1468
Signed-off-by: Atin Mukherjee [email protected]